Update html template css to better handle full screen canvas window#44
Open
claudijo wants to merge 1 commit intobevyengine:mainfrom
Open
Update html template css to better handle full screen canvas window#44claudijo wants to merge 1 commit intobevyengine:mainfrom
claudijo wants to merge 1 commit intobevyengine:mainfrom
Conversation
…true` window option
alice-i-cecile
approved these changes
Oct 16, 2023
|
I can confirm that these change make the itch.io fullscreen mode work. But as the bevy PR, it also requires to set So I suggest that we also update the This way, the template fully work for itch.io publication out of the box. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update css in index.html according to the discussion bevyengine/bevy#4726 under the heading Easy "fullscreen window" mode for the default canvas.
Before this change setting window option
fit_canvas_to_parenttotrueand building for the web will result in the canvas element growing vertically each time the window is resized regardless if the window is made wider or narrower. Also the canvas element height is not adjusted correctly if loaded in a browser window with a height is less than the canvas height.With this change the canvas element grows and fits the browser window as expected, not least if published to itch.io and loaded in a mobile web browser.